-
Notifications
You must be signed in to change notification settings - Fork 989
cgo: fixes panic when FuncType.Results is nil #3136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5df6c9d
to
2b8e5b1
Compare
macOS failure looks like the same as #2892 ?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that actually tests for the issue in #3096? It looks like a particular kind of code triggers it, which is not covered in the cgo/testdata/*.go files.
The |
@codefromthecrypt did you see @aykevl comment on this PR? |
@deadprogram thanks I missed it. yeap I can add a second layer test beyond the unit tests. np |
FuncType.Results can be nil. This fixes the comparison and backfills relevant tests. Signed-off-by: Adrian Cole <adrian@tetrate.io>
Co-authored-by: Ayke <aykevanlaethem@gmail.com>
b2a9231
to
551203f
Compare
@FGadvancer I fixed the bug, but we should have an integration test that makes sure it stays fixed. Can you paste the code that led to this panic? It is better than me wildly guessing. |
It took a while for me to figure out from the stack trace what the bug was, but am over budget doing more than work provided. If someone is interested in raising a PR to obviate this adding the second layer of tests, works for me. If only one layer of tests isn't good enough and this bug is tolerable meanwhile, I also don't mind if someone closes this. |
This seems better than it is right now, at the very least. Now squash/merging thank you for the code @codefromthecrypt |
FuncType.Results can be nil. This fixes the comparison and backfills relevant tests.
Fixes #3096