interp: fix maps with string values #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
force-pushed
the
fix-interp-lifetime-calls
branch
3 times, most recently
from
22822b6 to
96e3aac
Compare
|
The first commit gets image/jpeg to work. The second commit breaks the syscall package... |
aykevl
force-pushed
the
fix-interp-lifetime-calls
branch
from
96e3aac to
7d0c224
Compare
This fixes a bug found when updating a map with string keys. Originally reported here: hybridgroup/gdg-2019#6
This is a limitation in the PutString/PutBinary calls, make sure that they won't get non-constant values as a safety measure.
aykevl
force-pushed
the
fix-interp-lifetime-calls
branch
from
7d0c224 to
48b7f03
Compare
|
Hopefully it'll work now... |
|
We for sure needed this. Merging, thanks @aykevl |
aykevl
added a commit
that referenced
this pull request
Dec 20, 2019
Accidentally left in the source in #787.
deadprogram
pushed a commit
that referenced
this pull request
Dec 20, 2019
Accidentally left in the source in #787.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.