Skip to content

fix: prevent esm build global require pollution #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix: prevent esm build global require pollution #24

merged 1 commit into from
Aug 8, 2024

Conversation

bluwy
Copy link
Contributor

@bluwy bluwy commented Aug 8, 2024

fix #23

Use banner as long as we know the output bundle doesn't already declare a top-level require variable as well.

@43081j 43081j merged commit 9f3ed89 into tinylibs:main Aug 8, 2024
@bluwy bluwy deleted the esm-require-build branch August 8, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@43081j 43081j 43081j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESM bundle polyfills require globally
2 participants
@bluwy @43081j