Skip to content

fix: Routes for transactions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2023
Merged

fix: Routes for transactions #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9ecf76
fix: Routes for transactions
ZeroWave022 Apr 30, 2023
a7ed6ec
fix: Set some properties as possibly null
ZeroWave022 Apr 30, 2023
99c3917
fix: Change jsdocs
ZeroWave022 Apr 30, 2023
07e9a43
refactor: Rename functions
ZeroWave022 Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions payloads/v0/account.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ export enum APIService {

export interface APIConnection {
identifier: string;
username?: string;
avatar_url?: string;
username: string | null;
avatar_url: string | null;
service: APIService;
}

Expand All @@ -52,7 +52,7 @@ export interface APIWallet {
usd_value: APIMonetary;
}

export interface APIWithdrawl {
export interface APIWithdrawal {
id: string;
txid: string;
amount: APIMonetary;
Expand Down
2 changes: 1 addition & 1 deletion payloads/v0/currencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export interface APICoin {
export interface APIExchangeRate {
code: string;
name: string;
usd_value?: APIMonetary;
usd_value: APIMonetary | null;
}

export interface APICryptoCurrencyUnit {
Expand Down
4 changes: 2 additions & 2 deletions rest/v0/account.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type {
APITip,
APITransaction,
APIWallet,
APIWithdrawl,
APIWithdrawal,
} from '../../payloads/v0/account';
import type {
APICoin,
Expand Down Expand Up @@ -106,7 +106,7 @@ export interface RESTPostAPIAccountWalletWithdrawalPath {
*/
export interface RESTPutAPIAccountWalletWithdrawalResult {
id: string;
withdrawal: APIWithdrawl;
withdrawal: APIWithdrawal;
balance: APIMonetary;
}

Expand Down
12 changes: 6 additions & 6 deletions rest/v0/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,17 +65,17 @@ export const Routes = {
},
/**
* Route for:
* - GET `/account/wallets/transactions` - List of user's tips, deposits and withdrawals
* - GET `/account/transactions` - List of user's tips, deposits and withdrawals
*/
accountWalletTransactions() {
return '/account/wallets/transactions' as const;
accountTransactions() {
return '/account/transactions' as const;
},
/**
* Route for:
* - GET `/account/wallets/transactions/{id}` - Get a single tip, deposit or withdrawal by ID
* - GET `/account/transactions/{id}` - Get a single tip, deposit or withdrawal by ID
*/
accountWalletTransaction(id: string) {
return `/account/wallets/transactions/${id}` as const;
accountTransaction(id: string) {
return `/account/transactions/${id}` as const;
},
/**
* Route for:
Expand Down