Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request of pull requests #128

Merged
merged 27 commits into from
Sep 4, 2014
Merged

Pull request of pull requests #128

merged 27 commits into from
Sep 4, 2014

Conversation

Twipped
Copy link
Collaborator

@Twipped Twipped commented Sep 2, 2014

This PR merges the following existing PRs under a single merge that is resolved against master and cleaned up for project standards and tests. Some original commits were squashed in the process of making these fixes, apologies to those contributors.

I believe these changes also render the following PRs redundant:

I've also added the top contributors to the package.json (according to github) and addressed a few context conditions that were missing.

I'm 90% certain that there's no breaking changes in this, but I would still recommend bumping the next release to 0.5 if this is accepted.

oncletom and others added 27 commits September 18, 2013 09:24
commit 30a97fba5202ad1f5865e039d92a34e86f0aeb5f
Author: ChiperSoft <chiper@chipersoft.com>
Date:   Wed Aug 27 11:51:50 2014 -0700

    Line numbers fully working

commit d14b45837b462ef22db1ba9cee280131dd99b43c
Merge: 725e09b bda0a96
Author: ChiperSoft <chiper@chipersoft.com>
Date:   Wed Aug 27 08:50:23 2014 -0700

    Merge branch 'master' into linenum

    Conflicts:
    	lib/dox.js

commit 725e09b
Author: Stephen Oney <swloney@gmail.com>
Date:   Mon Dec 16 13:39:18 2013 -0500

    small modifications

commit 39beee0
Author: Stephen Oney <swloney@gmail.com>
Date:   Mon Dec 16 13:35:04 2013 -0500

    Added line_num
commit 30d822a81fc6c621e8f9677688e5564b687f7d20
Author: ChiperSoft <chiper@chipersoft.com>
Date:   Wed Aug 27 13:50:12 2014 -0700

    Lint skipping properly

commit 7523b93a29d21ba2654070ea5d0720cea6981968
Merge: 52fb67a 132babf
Author: ChiperSoft <chiper@chipersoft.com>
Date:   Wed Aug 27 13:43:58 2014 -0700

    Merge branch 'master' into lint

commit 52fb67a46d53255922bd3f4daf3177383d36c6b7
Author: ChiperSoft <chiper@chipersoft.com>
Date:   Wed Aug 27 13:16:40 2014 -0700

    attempting more accurate matching

commit 09ec2546a697b99f9a016d5e75de2981a1b36a7f
Merge: 7c5a8bf 3cc4615
Author: ChiperSoft <chiper@chipersoft.com>
Date:   Wed Aug 27 12:25:49 2014 -0700

    Merge branch 'master' into lint

    Conflicts:
    	lib/dox.js
    	test/dox.test.js

commit 7c5a8bf
Author: Russ Frank <rf@uber.com>
Date:   Tue Jun 10 16:30:42 2014 +0000

    checking if prefix is a prefix rather than substr

commit 2e7591e
Author: Russ Frank <rf@uber.com>
Date:   Mon Jun 9 15:19:32 2014 +0000

    skipPrefix option for skipping linter flags

commit f01f659
Author: Russ Frank <rf@uber.com>
Date:   Mon Jun 9 15:11:44 2014 +0000

    also ignoring eshint and jslint directives

commit 21836de
Author: Russ Frank <rf@uber.com>
Date:   Fri Jun 6 21:50:17 2014 +0000

    Ignore jshint directives. Fixes #74
@evindor
Copy link
Collaborator

evindor commented Sep 2, 2014

Wow, it is huge! Great job!
I agree on bumping version to 0.5, let me review this PR carefully.

@Twipped Twipped mentioned this pull request Sep 4, 2014
evindor added a commit that referenced this pull request Sep 4, 2014
Pull request of pull requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants