-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compile files #68
base: master
Are you sure you want to change the base?
Conversation
@tj Sorry to ask, but are you still maintaining the repo? Do you want some help? |
internal/prune/prune.go
Outdated
@@ -82,6 +82,7 @@ var DefaultFiles = []string{ | |||
".appveyor.yml", | |||
"tsconfig.json", | |||
"tslint.json", | |||
"package-lock.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm always ignore this file https://docs.npmjs.com/cli/v7/configuring-npm/package-json#files
internal/prune/prune.go
Outdated
@@ -82,8 +82,6 @@ var DefaultFiles = []string{ | |||
".appveyor.yml", | |||
"tsconfig.json", | |||
"tslint.json", | |||
"package-lock.json", | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you remove closing bracket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My laziness is damn too high 😅
I've add |
What does this PR do
Remove files needed to compile native add-ons (
.cpp
,.h
,.o
etc)Remove the
package-lock.json
since it's not needed anymore after installing dependencies.Remove
man
directory (man pages),features
(cucumber) and.git