Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pomo stop #28

Open
stephenmckinney opened this issue Dec 16, 2012 · 6 comments
Open

Add pomo stop #28

stephenmckinney opened this issue Dec 16, 2012 · 6 comments
Milestone

Comments

@stephenmckinney
Copy link
Collaborator

Stopping a task should include:

  • killing pomo PID
  • setting running task to false
  • resetting ~/.pomo_stat to #[default]#[fg=green]00:00#[default]

Possible option for maintaining processes: https://github.com/rjackson/singleton_process

@ghost
Copy link

ghost commented Jan 24, 2013

Yeah, we need 'pomo stop'. Now I use this script to kill the running pomo.

kill -9 $(ps aux | awk '/bin\/pomo/ {print $2}') 2> /dev/null
sed 's/running: true/running: false/g' ~/.pomo > ~/.pomo_temp
mv ~/.pomo_temp ~/.pomo
echo '#[default]#[fg=green]00:00#[default]' > ~/.pomo_stat

@stephenmckinney
Copy link
Collaborator Author

Good point on reseting ~/.pomo_stat. I updated the ticket.

I'd like to write a pid file on fork and use that to kill the process, I just haven't had time to code it up. A pomo pause would be great too.

@jhwist
Copy link

jhwist commented Feb 20, 2013

With pomo pause it would then be also possible to count the interruptions for a particular pomo.

@cbfrance
Copy link

+1 for stop or pause functionality

@stephenmckinney
Copy link
Collaborator Author

Unless there are any objections, I am going to make pomo run exclusively as a background process and eliminate pomo start --progress. This will make this feature much easier to implement and it seems no one is using it as a foreground process anyway.

@jhwist
Copy link

jhwist commented Mar 5, 2013

Well, yes I am using it ... on Windows, gasp, as Ruby lacks native fork support there and running in foreground is a nice workaround.
Having said that, go ahead and kill --progress as I'd rather see tomato support first. I can come up with a hack for Windows later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants