Skip to content

Incorrect minimal semver version for getset dependency #77

@regexident

Description

@regexident

The getset dependency uses 0.1:

[dependencies]
getset = "0.1"

https://github.com/tjtelan/git-url-parse-rs/blob/main/Cargo.toml#L26

But the CloneGetters type is only available since 0.1.6.

This is causing semver issue for downstream crates.

The fix for this is straight-forward:

[dependencies]
getset = "0.1.6"

To reproduce install cargo-minimal-versions and then run this:

cargo minimal-versions check --workspace --tests --ignore-private -v
error[E0432]: unresolved import `getset::CloneGetters`
 --> src/types/provider/gitlab.rs:4:14
  |
4 | use getset::{CloneGetters, Getters};
  |              ^^^^^^^^^^^^
  |              |
  |              no `CloneGetters` in the root
  |              help: a similar name exists in the module: `CopyGetters`

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions