Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cachetools.keys.typedmethodkey? #296

Closed
kuraga opened this issue Feb 16, 2024 · 3 comments
Closed

cachetools.keys.typedmethodkey? #296

kuraga opened this issue Feb 16, 2024 · 3 comments
Assignees

Comments

@kuraga
Copy link
Contributor

kuraga commented Feb 16, 2024

There are:

  • cachetools.keys.hashkey,
  • cachetools.keys.methodkey,
  • cachetools.keys.typedkey.

Should be there the cachetools.keys.typedmethodkey? Thanks!

@tkem
Copy link
Owner

tkem commented Feb 25, 2024

@kuraga Thnaks for the input! typedkey is used in the cachetools.func wrappers, and nobody expressed any interest in a typedmethodkey so far. For the sake of completeness, however, this might be added.

@kuraga
Copy link
Contributor Author

kuraga commented Feb 26, 2024

For the sake of completeness, however, this might be added.

Implemented in #301 #305.

@kuraga
Copy link
Contributor Author

kuraga commented Feb 27, 2024

New PR: #305.

tkem pushed a commit that referenced this issue Apr 10, 2024
tkem pushed a commit that referenced this issue May 1, 2024
tkem pushed a commit that referenced this issue May 28, 2024
@tkem tkem closed this as completed in e669b99 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants