Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the keys.typedmethodkey decorator #305

Closed
wants to merge 1 commit into from
Closed

Add the keys.typedmethodkey decorator #305

wants to merge 1 commit into from

Conversation

kuraga
Copy link
Contributor

@kuraga kuraga commented Feb 27, 2024

Closes: #296

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1fcadea) to head (091e61e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #305   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          666       668    +2     
=========================================
+ Hits           666       668    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkem
Copy link
Owner

tkem commented Apr 1, 2024

Sorry for the delay, but I promise I'll look into this in more detail by the end of April, latest!

@@ -491,7 +491,7 @@ functions with the :func:`cached` and :func:`cachedmethod` decorators:

.. autofunction:: methodkey

This function is equivalent to :func:`hashkey`, but ignores its
This function is similar to :func:`hashkey`, but ignores its
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the tests alone, this makes much more sense than previously. So 👍, thanks for your commitment (sorry for the bad joke, couldn't resist)!

@tkem
Copy link
Owner

tkem commented Apr 10, 2024

Merged into https://github.com/tkem/cachetools/tree/dev/v5.4.0, thanks!

@kuraga
Copy link
Contributor Author

kuraga commented Apr 10, 2024

Thanks!

@tkem
Copy link
Owner

tkem commented Jul 15, 2024

Should all be merged into v5.4.0.

@tkem tkem closed this Jul 15, 2024
@kuraga kuraga deleted the add-keys.typedmethodkey-decorator branch July 15, 2024 18:56
@kuraga
Copy link
Contributor Author

kuraga commented Jul 15, 2024

Thanks!

@tkem
Copy link
Owner

tkem commented Jul 15, 2024

No, thank you, and sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cachetools.keys.typedmethodkey?
3 participants