Fixed some bugs + added specs

[fschwahn]

Hi, I made the following changes:

• schema dumping didn't work before
• added regexp for checking if a string is a valid array
• added specs for the string and array extension, as well as integration specs

Best regards,
Fabian

[fschwahn]

this PR also fixes issue #2

[tlconnor]

Hi Fabian

I've merged your pull request and pushed a new gem to rubygems.org.
Thanks for your help.

Tim

On 6 February 2012 21:04, Fabian Schwahn
reply@reply.github.com
wrote:

Hi, I made the following changes:

• schema dumping didn't work before
• added regexp for checking if a string is a valid array
• added specs for the string and array extension, as well as integration specs

Best regards,
Fabian

You can merge this Pull Request by running:

 git pull https://github.com/fschwahn/activerecord-postgres-array master

Or you can view, comment on it, or merge it online at:

 #5

-- Commit Summary --

• correct mapping between array type and postgres type; fix dumping bug with string arrays
• added regexp for validating postgres arrays and specs for the regexp
• added integration specs using combustion, added specs for array methods
• explicitly require postgres adapter (fixes combustion issues)
• fixed validation regexp not working for empty postgres arrays
• fixed another possibility for an invalid case

-- File Changes --

M .gitignore (1)
A .rspec (2)
A Gemfile (3)
A Rakefile (13)
M activerecord-postgres-array.gemspec (7)
M lib/activerecord-postgres-array/activerecord.rb (36)
M lib/activerecord-postgres-array/array.rb (12)
M lib/activerecord-postgres-array/string.rb (23)
A spec/array_ext_spec.rb (26)
A spec/integration_spec.rb (86)
A spec/internal/app/models/article.rb (2)
A spec/internal/config/database.yml (6)
A spec/internal/db/schema.rb (6)
A spec/internal/log/.gitignore (1)
A spec/spec_helper.rb (12)
A spec/string_ext_spec.rb (105)

-- Patch Links --

 https://github.com/tlconnor/activerecord-postgres-array/pull/5.patch
 https://github.com/tlconnor/activerecord-postgres-array/pull/5.diff

---

Reply to this email directly or view it on GitHub:
#5