Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symlink pages.en to pages #11139

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Symlink pages.en to pages #11139

merged 2 commits into from
Oct 21, 2023

Conversation

acuteenvy
Copy link
Member

Closes #11121.

@github-actions github-actions bot added the tooling Helper tools, scripts and automated processes. label Oct 21, 2023
kbdharun

This comment was marked as outdated.

Sign in to view

@kbdharun kbdharun added the architecture Organization of the pages per language, platform, etc. label Oct 21, 2023
@kbdharun kbdharun self-assigned this Oct 21, 2023
@acuteenvy
Copy link
Member Author

Can you update the build assets script too and add tldr-pages-en.zip in addition to tldr-page.zip?

Which file needs updating? deploy.sh uses *.zip so it should move the symlink too.

@kbdharun
Copy link
Member

Can you update the build assets script too and add tldr-pages-en.zip in addition to tldr-page.zip?

Which file needs updating? deploy.sh uses *.zip so it should move the symlink too.

I didn't notice the additional file, I think this would do thanks.

@acuteenvy
Copy link
Member Author

I think that's everything. I haven't tested it on GitHub though.

@acuteenvy acuteenvy marked this pull request as ready for review October 21, 2023 19:03
kbdharun
kbdharun approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

gutjuri
gutjuri approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@sebastiaanspeck sebastiaanspeck merged commit af2f6d9 into tldr-pages:main Oct 21, 2023
4 checks passed
@acuteenvy acuteenvy deleted the symlink-pages.en branch October 28, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@gutjuri gutjuri gutjuri approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees

@kbdharun kbdharun

Labels
architecture Organization of the pages per language, platform, etc. tooling Helper tools, scripts and automated processes.
Projects
Architectural changes
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offer pages as pages.en
4 participants
@acuteenvy @kbdharun @sebastiaanspeck @gutjuri