Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub-editenv: add page #11218

Merged
merged 19 commits into from
Oct 25, 2023
Merged

grub-editenv: add page #11218

merged 19 commits into from
Oct 25, 2023

Conversation

SAYUK09
Copy link
Contributor

@SAYUK09 SAYUK09 commented Oct 24, 2023

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 24, 2023
@tldr-bot

This comment was marked as resolved.

@SAYUK09 SAYUK09 mentioned this pull request Oct 24, 2023
27 tasks
Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for contributing to this project, but unfortunately we can't accept this pull request, we advise to take a look to the style guide and update the file.

@tldr-bot

This comment was marked as resolved.

@SAYUK09
Copy link
Contributor Author

SAYUK09 commented Oct 25, 2023

Hi, thanks for contributing to this project, but unfortunately we can't accept this pull request, we advise to take a look to the style guide and update the file.

I have made the changes. Please take a look now.
Thanks @Magrid0

@tldr-bot

This comment was marked as resolved.

@tldr-bot

This comment was marked as resolved.

Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still not correct

pages/linux/grub-editenv.md Outdated Show resolved Hide resolved
pages/linux/grub-editenv.md Outdated Show resolved Hide resolved
pages/linux/grub-editenv.md Outdated Show resolved Hide resolved
@SAYUK09 SAYUK09 requested a review from Magrid0 October 25, 2023 12:37
@tldr-bot

This comment was marked as resolved.

@tldr-bot

This comment was marked as resolved.

@tldr-bot

This comment was marked as resolved.

Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this last change it should pass the check

pages/linux/grub-editenv.md Show resolved Hide resolved
pages/linux/grub-editenv.md Outdated Show resolved Hide resolved
pages/linux/grub-editenv.md Outdated Show resolved Hide resolved
pages/linux/grub-editenv.md Outdated Show resolved Hide resolved
pages/linux/grub-editenv.md Outdated Show resolved Hide resolved
@tldr-bot

This comment was marked as resolved.

Co-authored-by: Magrid <magrid0@proton.me>
@tldr-bot

This comment was marked as resolved.

@tldr-bot

This comment was marked as resolved.

@tldr-bot

This comment was marked as resolved.

@tldr-bot

This comment was marked as resolved.

SAYUK09 and others added 2 commits October 25, 2023 18:39
@tldr-bot

This comment was marked as resolved.

@tldr-bot

This comment was marked as resolved.

@tldr-bot

This comment was marked as resolved.

@tldr-bot

This comment was marked as resolved.

@kbdharun kbdharun self-assigned this Oct 25, 2023
@tldr-bot

This comment was marked as resolved.

@SAYUK09
Copy link
Contributor Author

SAYUK09 commented Oct 25, 2023

Thanks for helping our @kbdharun

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Welcome to tldr and thanks for your contribution.

@kbdharun kbdharun requested a review from Magrid0 October 25, 2023 13:41
Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution!

@kbdharun kbdharun merged commit b35049c into tldr-pages:main Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants