MAINTAINERS-GUIDE: remove minimum merge wait time requirement #11391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
kbdharun
changed the title
kbdharun
changed the title
kbdharun
commented
Nov 5, 2023
sebastiaanspeck
approved these changes
Nov 5, 2023
gutjuri
approved these changes
Nov 5, 2023
kbdharun
added a commit
that referenced
this pull request
Nov 6, 2023
kbdharun
added a commit
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This requirement was made initially when we had a couple of active maintainers only and didn't have things like Codeowners to review translation PRs. So as the project grows with multiple active maintainers I don't think we need this rule anymore, given that we have merged a significant portion of our PRs within 24 hours in the last year for even non-trivial additions/modifications.