Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ac, afconvert, airshare: fix typos in French translation #11517

Merged
merged 8 commits into from
Nov 16, 2023

Conversation

sebastiaanspeck
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the translation Translate pages from one language to another. label Nov 15, 2023
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you fix the spacing between description and symbols too, seems like we missed it while reviewing the previous PR.

@kbdharun kbdharun closed this Nov 16, 2023
@kbdharun kbdharun reopened this Nov 16, 2023
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the Codespell annotations issue for non-PR files still seems to exist 😵‍💫 (whatever fix we do it keeps coming back XD)

@sebastiaanspeck
Copy link
Member Author

sebastiaanspeck commented Nov 16, 2023

Seems like the Codespell annotations issue for non-PR files still seems to exist 😵‍💫 (whatever fix we do it keeps coming back XD)

Right now we only run on the English pages. This is correct, but since we ignore all translation folders, the changed files seems empty. If it is empty, it will run on all files (and so it will check the English pages).

We could only trigger the codespell if ${{ steps.changed-files.outputs.all_changed_files}} is not empty (or '') OR like this:
934fa85 - to only run codespell on pages/*/*.md. We could also add contributing-guides/style-guide.md in addition.

@sebastiaanspeck
Copy link
Member Author

This PR is the reason why I should want to trigger more linter checks.. this would have been detected in the previous PR and it will help us to detect these small typo’s.

@kbdharun
Copy link
Member

This PR is the reason why I should want to trigger more linter checks.. this would have been detected in the previous PR and it will help us to detect these small typo’s.

Agreed. For more info link script we can add maybe an argument like check and we can run it as part of the check PR script.

@kbdharun kbdharun changed the title ac, afconvert, airshare: fix French typo ac, afconvert, airshare: fix typos in French translation Nov 16, 2023
@sebastiaanspeck
Copy link
Member Author

This PR is the reason why I should want to trigger more linter checks.. this would have been detected in the previous PR and it will help us to detect these small typo’s.

Agreed. For more info link script we can add maybe an argument like check and we can run it as part of the check PR script.

Something to put on the tracker issue 2023 #11146?

@kbdharun
Copy link
Member

Something to put on the tracker issue 2023 #11146?

Yep

Copy link
Collaborator

@leonvsc leonvsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixes looks good to me!

@sebastiaanspeck sebastiaanspeck merged commit 11f0423 into main Nov 16, 2023
8 checks passed
@sebastiaanspeck sebastiaanspeck deleted the fr-update-more-info-link branch November 16, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants