-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ac, afconvert, airshare: fix typos in French translation #11517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you fix the spacing between description and symbols too, seems like we missed it while reviewing the previous PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the Codespell annotations issue for non-PR files still seems to exist 😵💫 (whatever fix we do it keeps coming back XD)
Right now we only run on the English pages. This is correct, but since we ignore all translation folders, the changed files seems empty. If it is empty, it will run on all files (and so it will check the English pages). We could only trigger the codespell if |
This PR is the reason why I should want to trigger more linter checks.. this would have been detected in the previous PR and it will help us to detect these small typo’s. |
Agreed. For more info link script we can add maybe an argument like check and we can run it as part of the check PR script. |
Something to put on the tracker issue 2023 #11146? |
Yep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo fixes looks good to me!
common
,linux
,osx
,windows
,sunos
,android
, etc.