COMMUNITY-ROLES: document CODEOWNERS file #11646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
kbdharun
approved these changes
Dec 2, 2023
sebastiaanspeck
requested changes
Dec 2, 2023
kbdharun
changed the title
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
sebastiaanspeck
requested changes
Dec 4, 2023
kbdharun
reviewed
Dec 5, 2023
There was a problem hiding this comment.
I think we can add a line or note saying something like (at maybe the start or the sections end):
Note
This mechanism is purely for automatic review requests for PRs and doesn't grant collaborators additional copyright over the code-owned files. View LICENSE file for more information.
This clause would avoid confusion with people who aren't aware of code owners and might think we dual license our code for contributors (granting them additional rights).
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
blueskyson
approved these changes
Dec 15, 2023
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
sebastiaanspeck
approved these changes
Dec 15, 2023
kbdharun
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://matrix.to/#/!zXiOpjSkFTvtMpsenJ:gitter.im/$P2PB65z9pBYv7KXAcTVv8p4WK_v3r1mx5cMyw5sgF2o?via=gitter.im&via=matrix.org&via=one.ems.host, this PR documents the
.github/CODEOWNERSfile in COMMUNITY-ROLES.It is of course completely everyones' choice as to whether they are in the CODEOWNERS file or not.