scripts/deploy.sh: exit immediately if there aren't any changes

[acuteenvy]

#11825 (comment) didn't work because it did the opposite - exit when there are changes, proceed if there aren't. I forgot to add a !.

---

I removed some of the variables used only once, because their contents were shorter than the variable name itself.

By the way, it would be great if we had some written conventions regarding the shell scripts.

• some scripts use $var, some ${var}
• some quote every variable, some don't, etc.

[kbdharun]

By the way, it would be great if we had some written conventions regarding the shell scripts.

Agreed, we could probably document them here https://github.com/tldr-pages/tldr/tree/main/scripts/README.md and update the scripts to have a consistent style.

[acuteenvy]

https://github.com/kbdkorg/tldr/actions/runs/7323410823/workflow

    - name: Build PDF
      if: github.repository == 'tldr-pages/tldr' && github.ref == 'refs/heads/main'
      working-directory: ./scripts/pdf
      run: bash build-pdf.sh

    - name: Deploy
      if: github.repository == 'tldr-pages/tldr' && github.ref == 'refs/heads/main'
      run: bash scripts/deploy.sh
      env:
        DEPLOY_KEY: ${{ secrets.DEPLOY_KEY }}

You are checking if github.repository == 'tldr-pages/tldr in kbdkorg/tldr, so the steps are skipped.

3 commits were merged into main while the changes were there and it worked just fine.

• tldr-pages/tldr-pages.github.io@67b4a6d
• tldr-pages/tldr-pages.github.io@54ed1e2
• tldr-pages/tldr-pages.github.io@e9deebd

[kbdharun]

@acuteenvy Thanks for pointing it out, I am extremely sorry for the mishap forgot to remove the lines (while testing).

[acuteenvy]

No problem. I don't think there's even a way to tell GitHub to skip the next step using shell commands in the previous one.

I think we could prevent this from happening in the future if we put the deployment steps in a different file without on: pull_request.

[kbdharun]

Tested the changes (it works fine). Thanks for the fixes.

[kbdharun]

I think we could prevent this from happening in the future if we put the deployment steps in a different file without on: pull_request.

Separating the CI for commits to main and for PRs? (It would work but then it would try to run on forks by default too, testing deployment is something that's rarely going to be done by others so IG we can leave it as it is, if it is required we can add a note to comment out the line when testing deploy, etc)

[sebastiaanspeck]

No problem. I don't think there's even a way to tell GitHub to skip the next step using shell commands in the previous one.

I normally let the previous step return an exit code of 1, this will skip the next steps, but if you want A, maybe skip B, but always C, you can specify if: always() at step C.

[sebastiaanspeck]

By the way, it would be great if we had some written conventions regarding the shell scripts.

Agreed, we could probably document them here https://github.com/tldr-pages/tldr/tree/main/scripts/README.md and update the scripts to have a consistent style.

Let's add it to the Tracker (for 2024?)