Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLIENT-SPECIFICATION: remove redirect indicators, use autolinks #12133

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

sbrl
Copy link
Member

@sbrl sbrl commented Jan 24, 2024

Autolinks are part of the CommonMark spec (ref https://spec.commonmark.org/0.30/#autolinks) and well supported.

Redirect indicators are removed as a part of #12048, which proposes splitting the assets/ directory in the GitHub repository for tldr.sh, our website into a separate repository, and extract the relevant history for tldr.sh and pushing it to a new repository.

This PR should be merged BEFORE the changes in #12048 are performed.

Autolinks are part of the CommonMark spec (ref <https://spec.commonmark.org/0.30/#autolinks>) and well supported.

Redirect indicators are removed as a part of #12048.
@sbrl sbrl requested a review from kbdharun as a code owner January 24, 2024 20:56
@github-actions github-actions bot added the documentation Issues/PRs modifying the documentation. label Jan 24, 2024
CLIENT-SPECIFICATION.md Outdated Show resolved Hide resolved
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM after @acuteenvy's suggestion.

sbrl and others added 2 commits January 26, 2024 23:55
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
@sbrl
Copy link
Member Author

sbrl commented Jan 26, 2024

Suggestion applied!

CLIENT-SPECIFICATION.md Outdated Show resolved Hide resolved
CLIENT-SPECIFICATION.md Outdated Show resolved Hide resolved
sbrl and others added 2 commits February 6, 2024 20:59
@kbdharun kbdharun removed the request for review from acuteenvy February 19, 2024 15:22
@kbdharun
Copy link
Member

Rebased this PR to update the changelog for unreleased alone as the text has been already edited in #12158 (which got merged recently accidentally). Will merge this one too, we can make a major client specification release after discussing the funding (i.e. Opencollective) topic in the chatroom [Btw, once things are finalized we can move the discussion to here or issue to not lose track of it].


Sorry, I accidentally re-requested a review when navigating through the page.

@kbdharun kbdharun merged commit 60640ac into main Feb 19, 2024
8 checks passed
@kbdharun kbdharun deleted the client-spec-redirects branch February 19, 2024 15:28
@kbdharun kbdharun added this to the v2.5 milestone Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues/PRs modifying the documentation. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants