Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd: fix incorrect math #12983

Merged
merged 6 commits into from
Jun 16, 2024
Merged

dd: fix incorrect math #12983

merged 6 commits into from
Jun 16, 2024

Conversation

CleanMachine1
Copy link
Member

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

Massive oversight here, just a 1TB test file...

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Jun 15, 2024
@@ -17,7 +17,7 @@

- Benchmark the write performance of a disk:

`dd bs={{1M}} count={{1000000}} if=/dev/zero of={{path/to/file_1GB}}`
`dd bs={{1024}} count={{1000000}} if=/dev/zero of={{path/to/file_1GB}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`dd bs={{1024}} count={{1000000}} if=/dev/zero of={{path/to/file_1GB}}`
`dd bs={{1024}} count={{1000000}} if=/dev/zero of={{path/to/file_1GB}}`

Please update the translation pages as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the other pages, they are all fine I believe

Copy link
Member

@sebastiaanspeck sebastiaanspeck Jun 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanMachine1 and others added 2 commits June 16, 2024 01:19
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
pages/linux/dd.md Outdated Show resolved Hide resolved
CleanMachine1 and others added 3 commits June 16, 2024 15:18
Co-authored-by: Fazle Arefin <fazlearefin@users.noreply.github.com>
@github-actions github-actions bot added the translation Translate pages from one language to another. label Jun 16, 2024
@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The page pages.ko/linux/dd.md is outdated, based on the command contents itself.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@CleanMachine1 CleanMachine1 merged commit 4e62f7f into main Jun 16, 2024
8 checks passed
@CleanMachine1 CleanMachine1 deleted the fix-dd-sizing branch June 16, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s). translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants