Skip to content

Conversation

rvandernoort
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

Updated gcrane main page according to #18255, populating it with more helpful commands.

Signed-off-by: rvandernoort <rovervandernoort@protonmail.com>
@github-actions github-actions bot added page edit Changes to an existing page(s). review needed Prioritized PRs marked for reviews from maintainers. labels Sep 30, 2025
@tldr-bot
Copy link

The build for this PR failed with the following error(s) at commit
30414ebaf7198c3930c72109596ead2743af8e0b:

pages/common/gcrane.md:18: TLDR103 Command example is missing its closing backtick

Please fix the error(s) and push again.

Signed-off-by: rvandernoort <rovervandernoort@protonmail.com>
@acuteenvy acuteenvy changed the title Update gcrane.md gcrane: update page Sep 30, 2025
Signed-off-by: rvandernoort <rovervandernoort@protonmail.com>
@Managor
Copy link
Member

Managor commented Oct 1, 2025

You should add a spelled out example at the end with a description "from a specific registry with a specific ID. Something like {{gcr.io}}/{{123456}}

Signed-off-by: rvandernoort <rovervandernoort@protonmail.com>
@rvandernoort
Copy link
Contributor Author

You should add a spelled out example at the end with a description "from a specific registry with a specific ID. Something like {{gcr.io}}/{{123456}}

Something like this?

Copy link
Member

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's pretty good. I felt like having a spelled out example would be good for understanding what the command should look like.

@Managor
Copy link
Member

Managor commented Oct 1, 2025

Also if you feel any of the commands on the original page were useful, feel free to include them in the new page. You decide as you're the expert in this case.

rvandernoort and others added 2 commits October 2, 2025 10:48
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Signed-off-by: rvandernoort <rovervandernoort@protonmail.com>
@rvandernoort
Copy link
Contributor Author

Also if you feel any of the commands on the original page were useful, feel free to include them in the new page. You decide as you're the expert in this case.

Original page did not a lot of useful stuff, however the current page mostly describes gcrane specific commands and it extends all the commands of crane as well as mentioned in the text. For now I added the login command here as well since I think that could be useful however adding more I don't know if its necessary. What do you think?

@Managor
Copy link
Member

Managor commented Oct 2, 2025

Also if you feel any of the commands on the original page were useful, feel free to include them in the new page. You decide as you're the expert in this case.

Original page did not a lot of useful stuff, however the current page mostly describes gcrane specific commands and it extends all the commands of crane as well as mentioned in the text. For now I added the login command here as well since I think that could be useful however adding more I don't know if its necessary. What do you think?

Pretty good. The user shouldn't have to go look in crane to find basic usage commands.

Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Copy link
Member

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for taking your time to document this.

@rvandernoort
Copy link
Contributor Author

No worries happy to help

@Managor Managor merged commit f5ff515 into tldr-pages:main Oct 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s). review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants