-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
gcrane: update page #18300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcrane: update page #18300
Conversation
Signed-off-by: rvandernoort <rovervandernoort@protonmail.com>
The build for this PR failed with the following error(s) at commit
Please fix the error(s) and push again. |
Signed-off-by: rvandernoort <rovervandernoort@protonmail.com>
Signed-off-by: rvandernoort <rovervandernoort@protonmail.com>
You should add a spelled out example at the end with a description "from a specific registry with a specific ID. Something like |
Signed-off-by: rvandernoort <rovervandernoort@protonmail.com>
Something like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's pretty good. I felt like having a spelled out example would be good for understanding what the command should look like.
Also if you feel any of the commands on the original page were useful, feel free to include them in the new page. You decide as you're the expert in this case. |
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Signed-off-by: rvandernoort <rovervandernoort@protonmail.com>
Original page did not a lot of useful stuff, however the current page mostly describes |
Pretty good. The user shouldn't have to go look in |
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
Co-authored-by: Managor <42655600+Managor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for taking your time to document this.
No worries happy to help |
common
,linux
,osx
,windows
,sunos
,android
, etc.Updated
gcrane
main page according to #18255, populating it with more helpful commands.