Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sqs: add page #9085

Merged
merged 2 commits into from
Oct 26, 2022
Merged

aws-sqs: add page #9085

merged 2 commits into from
Oct 26, 2022

Conversation

bryanmg
Copy link
Contributor

@bryanmg bryanmg commented Oct 15, 2022

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.

@CLAassistant

This comment was marked as outdated.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 15, 2022
@bryanmg bryanmg mentioned this pull request Oct 15, 2022
@navarroaxel
Copy link
Member

Hi @bryanmg, welcome and thanks for your submission. Could you please sign the license to pass the CLA check?

@bryanmg
Copy link
Contributor Author

bryanmg commented Oct 17, 2022

Screen Shot 2022-10-17 at 11 06 01

Hi @navarroaxel , it is suppose that I already accept the licence agreement. I've not idea if I'm doing something wrong. I've tried in safari, google chrome and google chrome incognito tab and I get the same result in each case

@navarroaxel
Copy link
Member

You created the commit using @bryan-guerrero as author. You should amend your commit using:

git commit --amend --author 'Your name <user@example.com>'
git push --force

And the name and email must match @bryanmg GitHub account.

@bryanmg
Copy link
Contributor Author

bryanmg commented Oct 20, 2022

Thanks @navarroaxel for your help, seems like it is ready for review 👍

pages/common/aws-sqs.md Outdated Show resolved Hide resolved
pages/common/aws-sqs.md Outdated Show resolved Hide resolved
pages/common/aws-sqs.md Outdated Show resolved Hide resolved
pages/common/aws-sqs.md Outdated Show resolved Hide resolved
pages/common/aws-sqs.md Outdated Show resolved Hide resolved
pages/common/aws-sqs.md Outdated Show resolved Hide resolved
pages/common/aws-sqs.md Outdated Show resolved Hide resolved
pages/common/aws-sqs.md Outdated Show resolved Hide resolved
pages/common/aws-sqs.md Outdated Show resolved Hide resolved
pages/common/aws-sqs.md Outdated Show resolved Hide resolved
@bryanmg
Copy link
Contributor Author

bryanmg commented Oct 25, 2022

Thanks for your review @navarroaxel all suggestion were manually applied

@navarroaxel navarroaxel merged commit bd623d6 into tldr-pages:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants