-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-sqs: add page #9085
Merged
Merged
aws-sqs: add page #9085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
new command
Issues requesting creation of a new page.
label
Oct 15, 2022
Hi @bryanmg, welcome and thanks for your submission. Could you please sign the license to pass the CLA check? |
Hi @navarroaxel , it is suppose that I already accept the licence agreement. I've not idea if I'm doing something wrong. I've tried in safari, google chrome and google chrome incognito tab and I get the same result in each case |
You created the commit using @bryan-guerrero as author. You should amend your commit using: git commit --amend --author 'Your name <user@example.com>'
git push --force And the name and email must match @bryanmg GitHub account. |
Thanks @navarroaxel for your help, seems like it is ready for review 👍 |
navarroaxel
reviewed
Oct 24, 2022
Thanks for your review @navarroaxel all suggestion were manually applied |
navarroaxel
approved these changes
Oct 26, 2022
kbdharun
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common
,linux
,osx
,windows
,sunos
,android
, etc.