-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf: block hit tests while moving camera #3418
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
so good |
@steveruizok instead of this could we just put the following line at the top of getShapeAtPoint ?
|
No this one addresses the browser's own hitTest function, which takes time as number of elements on the screen goes up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Not sure if the feature flag changes are leftovers from testing or if you wanted to commit them?
This PR uses an element that prevents hit tests on shapes while the camera is moving.
Kapture.2024-04-09.at.14.32.53.mp4
Change Type
sdk
— Changes the tldraw SDKimprovement
— Improving existing featuresTest Plan
Release Notes