Add a pitch tracker widget #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. all plots use the same function to handle kHz and include note name in the same way.
Retrospective note: The intent was to avoid detecting pitches in background noise, but it didn't end up working particularly well, for reasons explained in a later patch that introduces a more practical approach. I don't feel like doing the annoying rewriting that it would take to erase this false start from the record entirely ;)
|
Thanks @celeste-sinead, that's very nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows pitch over time.
The minimum SNR feature is kind of a false start that doesn't actually work all that great in practice; I have some following changes that work better but it was a little too annoying to rewrite it out of history entirely.