Skip to content

Conversation

blastZ
Copy link
Contributor

@blastZ blastZ commented Jan 17, 2018

No description provided.

@tleunen
Copy link
Owner

tleunen commented Jan 19, 2018

Hi @blastZ, I'm all good with the changes, but could you explain a bit what was the bug to make sure I understand why it's required?

@blastZ
Copy link
Contributor Author

blastZ commented Jan 19, 2018

Hi @tleunen, if you render multiple Gist components like
gists.map((gist) => (<Gist key={gist.id + gist.fileName} id={gist.id} file={gist.fileName} />))
you will get the same id of iframe, and the resize function will not work.

@tleunen
Copy link
Owner

tleunen commented Jan 19, 2018

Makes sense, thank you :)

@tleunen tleunen merged commit 677b4dd into tleunen:master Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants