-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace html-css-js-minify with minify_jll, eliminate Python3 dependency #1038
Conversation
Hello @M-PERSIC , thanks a lot for this, it's awesome and the PR is nice and clean. I will not merge this into Franklin however as the current status is kind of like an LTS release. The next version of Franklin is in preparation at Xranklin.jl and about 95% ready (mostly docs stuff at this point). The next version drops these external dependencies which caused issues and ultimately were not that useful.
Comments / next steps:
Thanks again for your proposal! |
@tlienart Thank you for your feedback!
|
I recently ported over Taco de Wolff's Minify to Julia as a JLL package and felt it would be an excellent addition to Franklin.
Advantages
Disadvantages
Considerations