Fix null analysis warnings from issue #28 #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused variable nullByteHash in ModifiableByteTest - Add explicit 'this' qualifier to field accesses in ModifiableIntegerTest These changes address static analysis warnings without changing functionality. The warning about methods being "potentially static" is a false positive for JUnit 5 test methods which cannot be static.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
This PR addresses some of the warnings reported in issue #28. The main warnings about test methods being "potentially static" are false positives from the static analysis tool, as JUnit 5 test methods cannot be static.
The changes made:
nullByteHashin ModifiableByteTest.javathisqualifier to field accesses in ModifiableIntegerTest.javaTest plan