Skip to content

Large hashes with small curves #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2019
Merged

Large hashes with small curves #168

merged 2 commits into from
Dec 16, 2019

Conversation

tomato42
Copy link
Member

fixes #129

@tomato42 tomato42 added the feature functionality to be implemented label Nov 30, 2019
@tomato42 tomato42 added this to the v0.15 milestone Nov 30, 2019
@tomato42 tomato42 self-assigned this Nov 30, 2019
@coveralls
Copy link

coveralls commented Nov 30, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 96.278% when pulling 73a245f on tomato42:large_hashes into 8deb089 on warner:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 94.758% when pulling 259a53c on tomato42:large_hashes into fed45a6 on warner:master.

@tomato42
support large hashes with small curves
70dd6ec 
While not recommended, it is well-defined, so allow use of large hashes
with small curve (like SHA-512 with NIST256p)

test against OpenSSL
@tomato42
silence tox about commands external to testenv
73a245f 
such use will not work in tox 4, so fix it before it breaks
sahanaprasad07
sahanaprasad07 approved these changes Dec 16, 2019
View reviewed changes
Copy link

@sahanaprasad07 sahanaprasad07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!
nit : specify where it is well-defined in the commit description - a doc reference and maybe mention the RFC that does not recommend the usage
( While not recommended, it is well-defined)

@tomato42
Copy link
Member Author

It's specified in X9.62 but it's not freely available – the fact that it interoperates with openssl will need to suffice.

I wasn't able to find either RFC or NIST SP document that would explicitly state the procedure (both redirect to X9.62)

@tomato42 tomato42 merged commit fc5cb54 into tlsfuzzer:master Dec 16, 2019
@tomato42 tomato42 deleted the large_hashes branch December 16, 2019 15:16
@blag blag mentioned this pull request Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sahanaprasad07 sahanaprasad07 sahanaprasad07 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tomato42 tomato42

Labels

feature functionality to be implemented

Projects

None yet

Milestone

v0.15

Development

Successfully merging this pull request may close these issues.

Support large hashes with small curves

3 participants

@tomato42 @coveralls @sahanaprasad07