Skip to content

handle private keys equal to n-1 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2020
Merged

handle private keys equal to n-1 #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/ecdsa/ellipticcurve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,8 +619,12 @@ def mul_add(self, self_mul, other, other_mul):
X1, Y1 = self.__x, self.__y
other = other.scale()
X2, Y2 = other.__x, other.__y
both = (self + other).scale()
X4, Y4 = both.__x, both.__y
both = self + other
if both is INFINITY:
X4, Y4 = 0, 0
else:
both.scale()
X4, Y4 = both.__x, both.__y
_double = self._double
_add = self._add
while i > 1:
Expand Down
8 changes: 8 additions & 0 deletions src/ecdsa/test_keys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
sigdecode_der,
sigdecode_strings,
)
from .curves import NIST256p


class TestVerifyingKeyFromString(unittest.TestCase):
Expand Down Expand Up @@ -408,3 +409,10 @@ def test_SigningKey_sign_digest(convert):
sig = sk.sign_digest(convert(data_hash))

vk.verify(sig, data)


def test_SigningKey_with_unlikely_value():
sk = SigningKey.from_secret_exponent(NIST256p.order - 1, curve=NIST256p)
vk = sk.verifying_key
sig = sk.sign(b"hello")
assert vk.verify(sig, b"hello")