Skip to content

tighter bounds for hypothesis parameters #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2022
Merged

tighter bounds for hypothesis parameters #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ecdsa/test_ecdsa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,12 +622,12 @@ def st_random_gen_key_msg_nonce(draw):
name = draw(st.sampled_from(sorted(name_gen.keys())))
note("Generator used: {0}".format(name))
generator = name_gen[name]
order = int(generator.order())
order = int(generator.order()) - 1

key = draw(st.integers(min_value=1, max_value=order))
msg = draw(st.integers(min_value=1, max_value=order))
nonce = draw(
st.integers(min_value=1, max_value=order + 1)
st.integers(min_value=1, max_value=order)
| st.integers(min_value=order >> 1, max_value=order)
)
return generator, key, msg, nonce
Expand Down
2 changes: 1 addition & 1 deletion src/ecdsa/test_ellipticcurve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@


@settings(**HYP_SLOW_SETTINGS)
@given(st.integers(min_value=1, max_value=r + 1))
@given(st.integers(min_value=1, max_value=r - 1))
def test_p192_mult_tests(multiple):
inv_m = inverse_mod(multiple, r)

Expand Down
20 changes: 10 additions & 10 deletions src/ecdsa/test_jacobi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def test_compare_double_with_multiply(self):
@settings(max_examples=10)
@given(
st.integers(
min_value=0, max_value=int(generator_brainpoolp160r1.order())
min_value=0, max_value=int(generator_brainpoolp160r1.order() - 1)
)
)
def test_multiplications(self, mul):
Expand All @@ -217,7 +217,7 @@ def test_multiplications(self, mul):
@settings(max_examples=10)
@given(
st.integers(
min_value=0, max_value=int(generator_brainpoolp160r1.order())
min_value=0, max_value=int(generator_brainpoolp160r1.order() - 1)
)
)
@example(0)
Expand All @@ -235,10 +235,10 @@ def test_precompute(self, mul):
@settings(max_examples=10)
@given(
st.integers(
min_value=1, max_value=int(generator_brainpoolp160r1.order())
min_value=1, max_value=int(generator_brainpoolp160r1.order() - 1)
),
st.integers(
min_value=1, max_value=int(generator_brainpoolp160r1.order())
min_value=1, max_value=int(generator_brainpoolp160r1.order() - 1)
),
)
@example(3, 3)
Expand All @@ -254,10 +254,10 @@ def test_add_scaled_points(self, a_mul, b_mul):
@settings(max_examples=10)
@given(
st.integers(
min_value=1, max_value=int(generator_brainpoolp160r1.order())
min_value=1, max_value=int(generator_brainpoolp160r1.order() - 1)
),
st.integers(
min_value=1, max_value=int(generator_brainpoolp160r1.order())
min_value=1, max_value=int(generator_brainpoolp160r1.order() - 1)
),
st.integers(min_value=1, max_value=int(curve_brainpoolp160r1.p() - 1)),
)
Expand Down Expand Up @@ -286,10 +286,10 @@ def test_add_one_scaled_point(self, a_mul, b_mul, new_z):
@settings(max_examples=10)
@given(
st.integers(
min_value=1, max_value=int(generator_brainpoolp160r1.order())
min_value=1, max_value=int(generator_brainpoolp160r1.order() - 1)
),
st.integers(
min_value=1, max_value=int(generator_brainpoolp160r1.order())
min_value=1, max_value=int(generator_brainpoolp160r1.order() - 1)
),
st.integers(min_value=1, max_value=int(curve_brainpoolp160r1.p() - 1)),
)
Expand Down Expand Up @@ -351,10 +351,10 @@ def test_add_same_scale_points_static(self):
@settings(max_examples=14)
@given(
st.integers(
min_value=1, max_value=int(generator_brainpoolp160r1.order())
min_value=1, max_value=int(generator_brainpoolp160r1.order() - 1)
),
st.integers(
min_value=1, max_value=int(generator_brainpoolp160r1.order())
min_value=1, max_value=int(generator_brainpoolp160r1.order() - 1)
),
st.lists(
st.integers(
Expand Down