Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest version #6

Closed
monte91 opened this issue Aug 21, 2022 · 19 comments · Fixed by #7
Closed

latest version #6

monte91 opened this issue Aug 21, 2022 · 19 comments · Fixed by #7

Comments

@monte91
Copy link

monte91 commented Aug 21, 2022

Just saw this and it seemed amazing, but unfortunetly it dosn''t work. It just says ready for paimon and game closed when i close the game. Maybe the game files blocked it or something, any tips? win10, 3080ti, running in fullscreen/windowed with 1 monitor.

@tmarenko
Copy link
Owner

What's your in-game screen resolution?

@monte91
Copy link
Author

monte91 commented Aug 21, 2022

3,840 by 2,160

@monte91
Copy link
Author

monte91 commented Aug 21, 2022

i evn tried 1080p windowed still nothing

@tmarenko
Copy link
Owner

What's language for text/UI are you using in the game? Script only works for eng version e.g. when Paimon's name is Paimon

@tmarenko
Copy link
Owner

Tested latest release and it works for me. Win10, 3070, fullscreen 1 monitor at 1080p, eng language
image

@monte91
Copy link
Author

monte91 commented Aug 23, 2022

i'ts english and using 1 monitor

@monte91
Copy link
Author

monte91 commented Aug 23, 2022

I tried 1080p full/win, taking off admin access/re adding it, maybe i need a set of drivers for the program?

@tmarenko
Copy link
Owner

tmarenko commented Aug 23, 2022

No, it should work with default DirectX capture. Script probably can't capture the game properly or fails to recognize Paimon's name in cutscenes.
I can make a debug version of the script in order to find out what's happening. If you want to test it

@monte91
Copy link
Author

monte91 commented Aug 23, 2022

I would appreciate it, thank you.

@tmarenko
Copy link
Owner

I've added debug branch: main...debug
Build: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/2922618159
Download link: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/suites/7969356444/artifacts/340753519

Run it while talking to any NPC or Paimon (for example you can spawn her in your Serenitea Pot)
When you run exe file you should see a debug window like this:
image

On top left you can see a cropped image that goes into OCR.
Somewhere in the middle you can see red and green rectangle. Usually one of them should contain NPC's name.

Also, debug window copies it's data to debug.png file as well.

@tmarenko
Copy link
Owner

Also please try this build
https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/2922700683
Download link: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/suites/7969564015/artifacts/340765734

It uses BitBlt function instead of PrintWindow to capture game image

@monte91
Copy link
Author

monte91 commented Aug 25, 2022

Also please try this build https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/2922700683 Download link: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/suites/7969564015/artifacts/340765734

It uses BitBlt function instead of PrintWindow to capture game image

It didn't cap the name
debug

@tmarenko
Copy link
Owner

Check your display settings in Windows. Do you have more than 100% scale? If so try with 100%
image

I've added debug branch: main...debug
Build: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/2922618159
Download link: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/suites/7969356444/artifacts/340753519

Did the first build work for you?

@monte91
Copy link
Author

monte91 commented Aug 25, 2022

I used the 2nd build and it works, but is there a way to configure it to work with 200% scaling?

@tmarenko
Copy link
Owner

tmarenko commented Aug 25, 2022

Yes, it's possible to make an application DPI aware so it'll properly capture with any scale.
Already made required changes: main...dpi_aware
Build (in progress, need to wait): https://github.com/tmarenko/GenshinImpact_PaimonShutUp/actions/runs/2926759286

@monte91
Copy link
Author

monte91 commented Aug 25, 2022

Cool, thank you

@tmarenko
Copy link
Owner

Download link: https://github.com/tmarenko/GenshinImpact_PaimonShutUp/suites/7979797769/artifacts/341497334
Let me know if it works for you

@monte91
Copy link
Author

monte91 commented Aug 26, 2022

yay it works, do you have a patreon or something?

tmarenko added a commit that referenced this issue Aug 26, 2022
Fix #6: BitBlt and set DPI Awareness
@tmarenko
Copy link
Owner

Fix released in https://github.com/tmarenko/GenshinImpact_PaimonShutUp/releases/tag/1.2.0

yay it works, do you have a patreon or something?

Hah, no, I don't =) happy to help you

@tmarenko tmarenko mentioned this issue Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants