Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LLMs to have optional parameters #64

Closed
ChristianSch opened this issue Apr 26, 2023 · 0 comments · Fixed by #78
Closed

Refactor LLMs to have optional parameters #64

ChristianSch opened this issue Apr 26, 2023 · 0 comments · Fixed by #78

Comments

@ChristianSch
Copy link

ChristianSch commented Apr 26, 2023

Quoting @tmc from #43 :

Let's do variadic/functional Options arguments to pass these (and have some reasonable defaults).

like

type Option func(LLM)

func New(options ...Option) (*LLM, error) {
    llm := &LLM{...}
    for _, o := range options {
       o(llm)
   }
}

/e: I wanted to also document which LLMs need to be updated, but as this is changing so quickly, I don't think that's feasible atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant