Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openaillm: new openaillm support options #78

Merged
merged 6 commits into from
May 11, 2023
Merged

openaillm: new openaillm support options #78

merged 6 commits into from
May 11, 2023

Conversation

yubing744
Copy link
Contributor

@yubing744 yubing744 commented May 3, 2023 •
edited
Loading

fixes #64 and #79

@tmc
Copy link
Owner

tmc commented May 4, 2023 •
edited
Loading

Thanks, this differs very slightly from the style in #80 but I'll think about it and refactor them to match. Could you address the lint failures?

@yubing744
Copy link
Contributor Author

Thanks, this differs very slightly from the style in #80 but I'll think about it and refactor them to match. Could you address the lint failures?

Okay, I will fix the lint.

@yubing744
Copy link
Contributor Author

@tmc I have fixed the lint errors.

tmc
tmc approved these changes May 11, 2023
View reviewed changes
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmc tmc enabled auto-merge May 11, 2023 00:24
@tmc tmc merged commit 33a3ac9 into tmc:main May 11, 2023
@obitech obitech mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmc tmc tmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor LLMs to have optional parameters
2 participants
@yubing744 @tmc