Fixes https://github.com/tmewett/BrogueCE/issues/45 #52
Conversation
|
Thanks for fixing this! If I'm not being a pain here.. could you remove the sub-heading in the CHANGELOG (so it's just a flat list - sorry, I meant to set this up around 1.8.1..) Will merge after that. Additionally, I would suggest expanding the commit message to be more descriptive of the change when not on GitHub (you can put Fixes: #45 in the message body. See the contributing guide) |
|
Sorry, not sure what you mean, could you please explain a bit more. It seems I'm missing some context. How GitHub commit message can ever be not on GitHub? Is it being copied somewhere? If yes where and by what process? |
|
I mean that when viewing the commits locally with Git, "fixes 45" isn't very descriptive, since I can't easily see what issue 45 is, like I can on GitHub (by mouse-over). |
|
Is this more of a theoretical issue (e.g. you think that it might cause some problems), or is it a practical one (e.g. you actually tried it and it proved unworkable for you)? I personally prefer to see commit history on GitHub, but even if I do this at command line I see this:
Now I can simply ctrl-click the link and read the details. It does not seem too onerous? |
|
it's just a matter of what I personally consider to be good practice. I like to be able to know what a commit does from reading its message. But I am happy to merge |
|
@tmewett understood, and thanks, I'll try to keep this in mind for the future, |
No description provided.