Fixing calling #on_headers_complete two times when parsing chunked requests #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chunk (this is triggering on headers callback two times)
|
Definitely looks like a bug. You should submit this patch to the upstream repository, not my fork. |
|
Just did:a2800276#6 However, it might take some time to get updated, and your fork is the one being submitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tmm1/http_parser.rb#52 .
As demonstrated by the script in the issue, the
#on_headers_completeis being called two times for such cases. I've singled it out to this line. I don't know if this affects tests (I currently don't have ant installed), so I hope it fixes the issue in a clean way.