Skip to content

Add search engines #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add search engines #8

wants to merge 3 commits into from

Conversation

lfv89
Copy link
Contributor

@lfv89 lfv89 commented Dec 23, 2014

Hey @bruno-

I'm creating another PR as you asked. Can you check to see if this one is alright?

@lfv89
Copy link
Contributor Author

lfv89 commented Dec 23, 2014

As I said on the other PR, this is how the .tmx.conf file can look like:

@open-S 'https://www.google.com.br/search?q='
@open-B 'https://www.bing.com.br/search?q='
@open-D 'https://www.duckduckgo.com/'

@bruno- bruno- closed this in 0e22a21 Jan 2, 2015
@bruno-
Copy link
Member

bruno- commented Jan 2, 2015

Hey, this is merged. I've done it via the command line because I wanted to do some whitespace updates 0e22a21 (using tabs instead of spaces for indentation).

I'll add you as the repo collaborator so you can make updates to the README so ppl know we have this new feature.

@bruno-
Copy link
Member

bruno- commented Jan 2, 2015

All right @vasconcelloslf, I just invited you to the team!

Let's just agree on one thing: we'll do all the changes via pull request so each of us can look at the changes being made, point improvements etc.

Also if we're about to make a bigger change, we're better off discussing it via an issue first.

Apart from that, welcome to the team! 🎉 🎉 (given that you accept the invite lol)

@lfv89
Copy link
Contributor Author

lfv89 commented Jan 17, 2015

Hey, sorry for the late reply. Thanks for the invitation, off course I will accept it!
All changes via PR, got it!
=)

@hoschi
Copy link

hoschi commented Feb 26, 2015

Can you put an example in README.md ? I didn't get it to work to :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants