Remove attached sessions limitation to not detect multiple attached clients #342
Conversation
Removes limitation of Server.attached_sessions to not being able to detect multiple attached clients
Timoses
force-pushed
the
feature/remove-attached-sessions-limitation
branch
from
2280a37 to
851856e
Compare
|
@tony : Done ; ) |
|
@Timoses Thank you! |
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
=======================================
Coverage 87.06% 87.06%
=======================================
Files 16 16
Lines 1515 1515
=======================================
Hits 1319 1319
Misses 196 196
Continue to review full report at Codecov.
|
| @@ -319,8 +319,6 @@ def attached_sessions(self): | |||
| """ | |||
| Return active :class:`Session` objects. | |||
|
|
|||
| This will not work where multiple tmux sessions are attached. | |||
There was a problem hiding this comment.
Hm, back in history, I'm wondering what I will thinking back then.
I guess there really wasn't a good rationale back then.
|
@Timoses Thank you! Would you like me to cut a new release of libtmux for this now? tmuxp? |
|
@Timoses This is live in |
Looks good.
Thanks, already tried it and it works : ). What I noticed though is that using more tmux introspection causes more "lag". As I am using libtmux in a real-time application I am now circumventing calling it too often: https://codeberg.org/timoses/caster-timoses/src/branch/master/caster_timoses/tmux/__init__.py#L19-L26 |
Technically this is a breaking change. Previously one could expect to detect that only one client is attached to the sessions via this property.
However, since previously
Server.attached_sessionswas broken (see #180 and PR to fix #341) I do not expect anybody to use the property currently.Builds on https://github.com/tmux-python/libtmux/pull/341/files (<- Merge first)