Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unobtrusive type hinting #359

Merged
merged 2 commits into from Mar 18, 2022
Merged

Conversation

otherJL0
Copy link
Contributor

Adding simple type hints in independent functions as a first step to introduce type hints to the project

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2022

CLA assistant check
All committers have signed the CLA.

libtmux/common.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #359 (5774e51) into master (071f1dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   87.89%   87.90%           
=======================================
  Files          15       15           
  Lines        1495     1496    +1     
=======================================
+ Hits         1314     1315    +1     
  Misses        181      181           
Impacted Files Coverage Δ
libtmux/common.py 86.93% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071f1dc...5774e51. Read the comment docs.

@tony tony self-requested a review March 18, 2022 17:46
Copy link
Member

@tony tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This will make it into 0.11, which will release tomorrow

afterward 3.7 and 3.8 will be dropped

@otherJL0 this Saturday i will be adding type annotations and data structures #360. If you're around and have any ideas/feedback/PR sugggestions you'd like to contribute feel free

@tony tony merged commit c30da96 into tmux-python:master Mar 18, 2022
tony added a commit that referenced this pull request Mar 18, 2022
@tony
Copy link
Member

tony commented Aug 5, 2022

@otherJL0 libtmux v0.13.0 has typings, if you'd like to try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants