0.15.3: Issues with pytester fixture #441
Description
Hi! When trying to package 0.15.3 on Arch Linux I ran into an issue with the test_plugin test:
==================================== ERRORS ====================================
________________________ ERROR at setup of test_plugin _________________________
file /build/python-libtmux/src/libtmux-0.15.3/tests/test_pytest_plugin.py, line 8
def test_plugin(
E fixture 'pytester' not found
> available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, clear_env, config_file, doctest_namespace, home_path, home_user_name, monkeypatch, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, server, session, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, user_path, zshrc
> use 'pytest --fixtures [testpath]' for help on them.
/build/python-libtmux/src/libtmux-0.15.3/tests/test_pytest_plugin.py:8
=========================== short test summary info ============================
ERROR tests/test_pytest_plugin.py::test_plugin
========================= 92 passed, 1 error in 8.86s ==========================
We are currently using python-pytest 7.1.3 on Arch Linux and the fixture should be somehow available. According to the pytest documentation it needs to be added in the configuration file. As you do not include your conftest.py in the sdist tarball, the configuration is missing though. FWIW, the conftest file can just reside in the tests directory.
Looking at the import of the internal functionality from _pytest I don't think it is a good idea to rely on it the way it is currently done. The internal implementations of pytest will change and they will break your tests.
It is much better to from pytest import Pytester.