Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implicit exports into __init__.py #531

Merged
merged 1 commit into from Mar 2, 2024
Merged

Conversation

ssbarnea
Copy link
Contributor

@ssbarnea ssbarnea commented Mar 1, 2024

Fixes: #530

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2024

CLA assistant check
All committers have signed the CLA.

@ssbarnea

This comment was marked as outdated.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.38%. Comparing base (48ea20b) to head (765d700).
Report is 77 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   88.76%   88.38%   -0.38%     
==========================================
  Files          37       37              
  Lines        3685     3798     +113     
  Branches      526      549      +23     
==========================================
+ Hits         3271     3357      +86     
- Misses        281      304      +23     
- Partials      133      137       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony self-requested a review March 2, 2024 00:29
Copy link
Member

@tony tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Sphinx autodoc still seems to work.

@tony tony merged commit 5a46a9a into tmux-python:master Mar 2, 2024
21 checks passed
@tony
Copy link
Member

tony commented Mar 2, 2024

@ssbarnea I will cut a feature-level package release so you can try this downstream.

tony added a commit that referenced this pull request Mar 2, 2024
@tony
Copy link
Member

tony commented Mar 2, 2024

@ssbarnea This is live in v0.32.0 (PyPI, release notes, changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No implicit exports from __init__.py
3 participants