enable opcache #444
enable opcache #444
Conversation
can someone please test these changes. i don't know if that is even the correct file to change... 😁 while being on it, i changed the default session timeout from 14 minutes to 1 week. the setting `opcache.validate_timestamps` might cause troubles for files changed during runtime (like updated invoice templates). we should mention in the docs, that a docker restart (actually fpm) is advised if file changes do not become visible in the container
|
I'm not sure what I need to do to test these changes, but I assume that I have to do |
|
but opcache is not an extension afaik, it is built in php. no clue, not a docker user 🤷but what about you ssh into the container, edit the file manually and apply my changes, restart fpm inside the container and check if performance improves. we first need to confirm whether the settings do any good - and then we can ask @tobybatch to put it into the image properly. |
|
@kevinpapst I'll take a look. |
|
Looks like the opcache settings are not set at all. I'll fix this. I'll do it in the next couple of days. |
|
@kevinpapst No, it's an extension. If you compile PHP manually you can compile it directly, but as far as I know in apt packages it is a separate package.
As hoped, I could notice a strong increase in speed. |
|
Ok, double checked and you are right, opcache is an extension. It is even in the Kimai installation docs ... never trust your own memory ^^ Anyhow, great that we have everything together now. And great that this rather simple chance will make a huge difference. |
|
Because I'm not able to change anything in this PR, I've created a new pr #446. I hope this is okay for you. 😊 |
|
LOL, happy that my PR pushed you to try it yourself ;-) but I would like to understand the configuration of the opcode cache. The default settings are suboptimal: too small for a symfony application with many files, caches and long uptimes. Can you add a phpinfo to the kimai public folder and copy & paste the result of the opcode settings? Then this PR can be used to improve them after yours activated the opcode cache. |
I think this should be the same settings as in web. |
|
I don't understand that docker container.
|
Zend OPcache
|
|
Thank you very much 👍 I just saw |
|
@kevinpapst Should I add your changes in this PR to my Dockerfile and try your changes? |
|
You could test if they work, yes please. I guess you will not see much difference for a single user though. But at least the validate_timestamps makes a huge IO difference, especially with many users. |
|
I tried it out but it seems that your changes doesn't have any effect. It seems that the replace doesn't work. {{php.ini}} values stays on default. Line 297 in 993e98e www-data@eeb903d9b49d:~/html$ cat /usr/local/etc/php/php.ini | grep expose_php
expose_php = OnI used build |
|
There was core bug with my sed operations in the Dockerfile and startup.sh. @kevinpapst I've lifted your code into a new PR #452 along with the bug fix. |
can someone please test these changes.
i don't know if that is even the correct file to change... 😁
while being on it, i changed the default session timeout from 14 minutes to 1 week.
the setting
opcache.validate_timestampsmight cause troubles for files changed during runtime (like updated invoice templates). we should mention in the docs, that a docker restart (actually fpm) is advised if file changes do not become visible in the containerdo not merge without testing, these changes were made blindly!!!