-
Notifications
You must be signed in to change notification settings - Fork 18
Microbit v2 serial bootloader release workflow #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ed2adea
to
192d8f8
Compare
I rebased this, |
Unfortunately this still seems to break travis (the current failure seems to be from using wildcard imports, which Tock's style rules forbid). |
All the PRs do this, it is not related to the changes in this PR. |
Oh, sorry. I don't review many PRs in the bootloader repo! |
This is cool! Can you revert the changes the the cargo files? |
If I use the git repository, the workflow stops due to some error when downloading qemu. I have the same problem when building it locally. |
That should be fixed once tock/tock#2323 is merged. Sorry about that. |
afc516b
to
dfaf939
Compare
Done. |
I changes the branch in Cargo.toml to |
Now that tock/tock#2323 is merged I think we can update the cargo.toml files for the last time and get this merged! |
8ae9e91
to
962e14f
Compare
It works now with master, the workflow is updated |
cd boards/microbit_v2-bootloader | ||
export BOOTLOADER_VERSION="${{ github.event.inputs.version }}" | ||
export BOOTLOADER_HASH="$(git rev-parse HEAD)" | ||
export BOOTLOADER_KERNEL_HASH="$(cat Cargo.lock | grep https://github.com/tock/tock?branch=remove-submodule | uniq | cut -d '#' -f 2 | cut -d '"' -f 1)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be master now?
echo "Version: ${{ github.event.inputs.version }}" > tock-bootloader.microbit_v2.version | ||
echo "Toolchain: $(rustc --version)" >> tock-bootloader.microbit_v2.version | ||
echo "Tock Bootloader Hash: $(git rev-parse HEAD)" >> tock-bootloader.microbit_v2.version | ||
echo Tock Hash: $(cat boards/microbit_v2-bootloader/Cargo.lock | grep https://github.com/tock/tock?branch=remove-submodule | uniq | cut -d '#' -f 2 | cut -d '"' -f 1) >> tock-bootloader.microbit_v2.version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, not sure how this checking out remove-submodule interacts with the Cargo.lock file using a commit on master
This PR adds a release workflow to generate a bootloader bin and version file and upload them to a github release.
The workflow is manually activated and asks for the bootloader version as a parameter.
I had to use the "development" dependencies as otherwise cargo clones the tock repository recursively (due to qemu) and the workflow throws a network error.
This PR is a followup for #21