Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): page info ui #5729

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jan 28, 2024

this PR includes the main table view in the page detail page

Copy link

graphite-app bot commented Jan 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@github-actions github-actions bot added mod:i18n Related to i18n mod:component test Related to test cases app:core labels Jan 28, 2024
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (46cc081) 45.39% compared to head (d97304e) 64.61%.

Files Patch % Lines
...ages/frontend/core/src/hooks/use-affine-adapter.ts 28.57% 5 Missing ⚠️
...d/core/src/modules/workspace/properties/adapter.ts 37.50% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #5729       +/-   ##
===========================================
+ Coverage   45.39%   64.61%   +19.22%     
===========================================
  Files         225      358      +133     
  Lines        5208    19920    +14712     
  Branches      922     1697      +775     
===========================================
+ Hits         2364    12871    +10507     
- Misses       2656     6830     +4174     
- Partials      188      219       +31     
Flag Coverage Δ
server-test 71.45% <ø> (?)
unittest 45.35% <44.44%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/01-25-feat_core_page_info_ui branch 7 times, most recently from a69f76e to 403df09 Compare January 29, 2024 14:40
@pengx17 pengx17 force-pushed the xp/01-25-feat_core_page_info_ui branch 5 times, most recently from 88103e2 to bfee81d Compare January 30, 2024 09:30
@pengx17 pengx17 force-pushed the xp/01-25-feat_core_page_info_ui branch from bfee81d to 3d40d87 Compare January 31, 2024 14:40
@pengx17 pengx17 marked this pull request as ready for review January 31, 2024 15:22
@pengx17 pengx17 force-pushed the xp/01-25-feat_core_page_info_ui branch 3 times, most recently from 89625ba to 385de2b Compare February 1, 2024 14:47
@pengx17 pengx17 force-pushed the xp/01-25-feat_core_page_info_ui branch from 34bf8b8 to b8363fd Compare February 5, 2024 06:15
@pengx17 pengx17 changed the base branch from canary to 02-05-fix_core_flaky_tests February 5, 2024 06:15
@pengx17 pengx17 force-pushed the xp/01-25-feat_core_page_info_ui branch from b8363fd to ff9338c Compare February 5, 2024 10:09
@pengx17 pengx17 force-pushed the xp/01-25-feat_core_page_info_ui branch from ff9338c to a65667f Compare February 6, 2024 02:49
@pengx17 pengx17 force-pushed the xp/01-25-feat_core_page_info_ui branch from a65667f to 1e6ff67 Compare February 6, 2024 03:08
@pengx17 pengx17 changed the base branch from 02-05-fix_core_flaky_tests to canary February 6, 2024 03:30
@pengx17 pengx17 force-pushed the xp/01-25-feat_core_page_info_ui branch from 1e6ff67 to edbdb25 Compare February 6, 2024 05:12
@pengx17 pengx17 force-pushed the xp/01-25-feat_core_page_info_ui branch from edbdb25 to 093491c Compare February 7, 2024 09:59
@pengx17 pengx17 force-pushed the xp/01-25-feat_core_page_info_ui branch 7 times, most recently from 069b549 to 93950cb Compare February 22, 2024 04:06
Copy link

graphite-app bot commented Feb 22, 2024

Merge activity

this PR includes the main table view in the page detail page
@graphite-app graphite-app bot merged commit d97304e into canary Feb 22, 2024
39 of 43 checks passed
@graphite-app graphite-app bot deleted the xp/01-25-feat_core_page_info_ui branch February 22, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:component mod:i18n Related to i18n test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants