Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(core): add tests for page info ui #5769

Merged
merged 1 commit into from
Feb 22, 2024
Merged

test(core): add tests for page info ui #5769

merged 1 commit into from
Feb 22, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 1, 2024 •
edited

image.png

@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

This was referenced Feb 1, 2024
Merged
Merged
@pengx17 Graphite App
Copy link
Collaborator Author

pengx17 commented Feb 1, 2024 •
edited

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@pengx17 pengx17 mentioned this pull request Feb 1, 2024
Merged
@github-actions github-actions bot added the test Related to test cases label Feb 1, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb8e601) 64.43% compared to head (372b4da) 64.34%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           canary    #5769      +/-   ##
==========================================
- Coverage   64.43%   64.34%   -0.10%     
==========================================
  Files         360      360              
  Lines       19945    19945              
  Branches     1702     1701       -1     
==========================================
- Hits        12851    12833      -18     
- Misses       6874     6892      +18     
  Partials      220      220
Flag Coverage Δ
server-test 71.23% <ø> (-0.13%) ⬇️
unittest 45.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 55473ce to 7dfeace Compare February 1, 2024 08:53
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from d20dd9e to b8cb067 Compare February 1, 2024 08:53
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 7dfeace to b3821e8 Compare February 1, 2024 09:06
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch 2 times, most recently from e668906 to 83cc41f Compare February 1, 2024 11:20
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from b3821e8 to c65505a Compare February 1, 2024 14:31
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 83cc41f to 7114ca9 Compare February 1, 2024 14:31
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from c65505a to 515c9a7 Compare February 1, 2024 14:47
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch 2 times, most recently from 9d1cd50 to fd86c80 Compare February 1, 2024 16:36
@github-actions github-actions bot added the mod:i18n Related to i18n label Feb 1, 2024
@pengx17 pengx17 requested a review from joooye34 February 1, 2024 16:38
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 515c9a7 to 41fc2d1 Compare February 2, 2024 01:42
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from fd86c80 to 61d24d5 Compare February 2, 2024 01:42
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 41fc2d1 to 2e4da8f Compare February 2, 2024 03:14
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 61d24d5 to 78042da Compare February 2, 2024 03:14
@pengx17 pengx17 mentioned this pull request Feb 2, 2024
Merged
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 2e4da8f to a37d159 Compare February 2, 2024 06:10
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 78042da to 1b913c3 Compare February 2, 2024 06:10
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from a37d159 to 6b6e4f6 Compare February 2, 2024 06:35
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 1b913c3 to 1dd87a6 Compare February 2, 2024 06:35
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from c359127 to 597463a Compare February 22, 2024 03:42
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 94a606f to 26a77b4 Compare February 22, 2024 03:42
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 597463a to 5379b08 Compare February 22, 2024 03:52
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 26a77b4 to b4fcac3 Compare February 22, 2024 03:52
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 5379b08 to 1bfdf02 Compare February 22, 2024 04:04
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from b4fcac3 to cd50a04 Compare February 22, 2024 04:04
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 1bfdf02 to a341aeb Compare February 22, 2024 04:06
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from cd50a04 to e85a727 Compare February 22, 2024 04:06
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from a341aeb to 03d05c1 Compare February 22, 2024 04:42
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from e85a727 to 8c88f63 Compare February 22, 2024 04:42
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 03d05c1 to c1e463b Compare February 22, 2024 07:28
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch 2 times, most recently from 8919212 to 9d538bb Compare February 22, 2024 07:55
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from c1e463b to dcbaa2a Compare February 22, 2024 07:57
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 9d538bb to b810be8 Compare February 22, 2024 07:57
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from dcbaa2a to c7ca4ed Compare February 22, 2024 08:05
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from b810be8 to bc65a31 Compare February 22, 2024 08:05
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from c7ca4ed to f88fbab Compare February 22, 2024 08:13
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from bc65a31 to 86b62e3 Compare February 22, 2024 08:13
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from f88fbab to 4bf407f Compare February 22, 2024 08:25
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 86b62e3 to 0e2d426 Compare February 22, 2024 08:25
@pengx17 pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 4bf407f to b5195a0 Compare February 22, 2024 09:24
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 0e2d426 to 4b608f8 Compare February 22, 2024 09:24
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 22, 2024 •
edited

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the xp/01-31-feat_core_tags_inline_editor branch from b5195a0 to bb8e601 Compare February 22, 2024 09:39
@Brooooooklyn Brooooooklyn force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 4b608f8 to 372b4da Compare February 22, 2024 09:39
@Brooooooklyn Brooooooklyn changed the base branch from xp/01-31-feat_core_tags_inline_editor to canary February 22, 2024 09:49
@graphite-app graphite-app bot merged commit 372b4da into canary Feb 22, 2024
34 checks passed
@graphite-app graphite-app bot deleted the xp/02-01-test_core_add_tests_for_page_info_ui branch February 22, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

@joooye34 joooye34 Awaiting requested review from joooye34

Assignees

@pengx17 pengx17

Labels
app:core mod:i18n Related to i18n test Related to test cases
Projects
AFFiNE Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pengx17 @Brooooooklyn