feat(core): tags inline editor #5748

pengx17 · 2024-01-30T16:38:59Z

tags inline editor and some refactor

🎥 Video uploaded on Graphite:

fix AFF-467
fix AFF-468
fix AFF-472
fix AFF-466

pengx17 · 2024-01-30T16:39:12Z

Current dependencies on/for this PR:

refactor(core): use fractional indexing for sorting #5809
test(core): add tests for page info ui #5769
feat(core): tags inline editor #5748 👈
feat(core): workspace properties setting #5739
feat(core): page info ui #5729
fix(core): flaky tests #5804
feat(core): add an option to throttle cpu in e2e #5803
canary

This stack of pull requests is managed by Graphite.

codecov · 2024-01-30T16:43:23Z

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (546d96c) 64.43% compared to head (bb8e601) 64.43%.

Files	Patch %	Lines
.../modules/workspace/properties/legacy-properties.ts	0.00%	26 Missing ⚠️
...ges/frontend/core/src/hooks/use-navigate-helper.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           canary    #5748      +/-   ##
==========================================
- Coverage   64.43%   64.43%   -0.01%     
==========================================
  Files         359      360       +1     
  Lines       19916    19945      +29     
  Branches     1697     1702       +5     
==========================================
+ Hits        12833    12851      +18     
- Misses       6863     6874      +11     
  Partials      220      220

Flag	Coverage Δ
server-test	`71.35% <ø> (+0.12%)`	⬆️
unittest	`45.10% <0.00%> (-0.26%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/frontend/component/src/ui/input/style.css.ts

graphite-app · 2024-02-22T09:36:38Z

Merge activity

Feb 22, 4:36 AM EST: Brooooooklyn added this pull request to the Graphite merge queue.
Feb 22, 4:49 AM EST: Brooooooklyn merged this pull request with the Graphite merge queue.

tags inline editor and some refactor <div class='graphite__hidden'> <div>🎥 Video uploaded on Graphite:</div> <a href="https://app.graphite.dev/media/video/T2klNLEk0wxLh4NRDzhk/439da1e3-30a9-462a-b7b4-c8e7c3b5ef17.mp4"> <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/T2klNLEk0wxLh4NRDzhk/439da1e3-30a9-462a-b7b4-c8e7c3b5ef17.mp4"> </a> </div> <video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/439da1e3-30a9-462a-b7b4-c8e7c3b5ef17.mp4">Kapture 2024-01-31 at 23.29.11.mp4</video> fix AFF-467 fix AFF-468 fix AFF-472 fix AFF-466

pengx17 mentioned this pull request Jan 30, 2024

feat(core): page info ui #5729

Merged

pengx17 mentioned this pull request Jan 30, 2024

feat(core): workspace properties setting #5739

Merged

github-actions bot assigned pengx17 Jan 30, 2024

github-actions bot added the app:core label Jan 30, 2024

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch 3 times, most recently from ca55f22 to 4f61059 Compare January 31, 2024 14:39

github-actions bot added mod:i18n Related to i18n mod:component labels Jan 31, 2024

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from b2a5d86 to 5f9c5e4 Compare January 31, 2024 14:40

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch 2 times, most recently from 10f246b to f6f3cc4 Compare January 31, 2024 15:17

pengx17 marked this pull request as ready for review January 31, 2024 15:22

pengx17 requested review from CatsJuice and joooye34 January 31, 2024 15:25

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch 2 times, most recently from 624e20e to 55473ce Compare February 1, 2024 07:22

pengx17 mentioned this pull request Feb 1, 2024

test(core): add tests for page info ui #5769

Merged

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 55473ce to 7dfeace Compare February 1, 2024 08:53

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 5f9c5e4 to 934caa2 Compare February 1, 2024 09:06

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 7dfeace to b3821e8 Compare February 1, 2024 09:06

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 934caa2 to 0da4982 Compare February 1, 2024 14:31

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from b3821e8 to c65505a Compare February 1, 2024 14:31

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 0da4982 to b5b1596 Compare February 1, 2024 14:47

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from c65505a to 515c9a7 Compare February 1, 2024 14:47

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from b5b1596 to 3f7b1c9 Compare February 2, 2024 01:42

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 515c9a7 to 41fc2d1 Compare February 2, 2024 01:42

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 3f7b1c9 to b0e5193 Compare February 2, 2024 03:14

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 228ee14 to 9c73a5a Compare February 22, 2024 03:42

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from c359127 to 597463a Compare February 22, 2024 03:42

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 9c73a5a to dd3d541 Compare February 22, 2024 03:52

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 597463a to 5379b08 Compare February 22, 2024 03:52

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from dd3d541 to 041a235 Compare February 22, 2024 04:04

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 5379b08 to 1bfdf02 Compare February 22, 2024 04:04

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 041a235 to 4fe16fa Compare February 22, 2024 04:06

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 1bfdf02 to a341aeb Compare February 22, 2024 04:06

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 4fe16fa to 71acd92 Compare February 22, 2024 04:42

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from a341aeb to 03d05c1 Compare February 22, 2024 04:42

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 71acd92 to 631a0be Compare February 22, 2024 07:28

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 03d05c1 to c1e463b Compare February 22, 2024 07:28

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 631a0be to c83ac5f Compare February 22, 2024 07:57

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from c1e463b to dcbaa2a Compare February 22, 2024 07:57

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from c83ac5f to 9d6ca47 Compare February 22, 2024 08:05

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from dcbaa2a to c7ca4ed Compare February 22, 2024 08:05

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 9d6ca47 to fd97c49 Compare February 22, 2024 08:13

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from c7ca4ed to f88fbab Compare February 22, 2024 08:13

pengx17 force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from fd97c49 to 98ef7e3 Compare February 22, 2024 08:24

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from f88fbab to 4bf407f Compare February 22, 2024 08:25

Brooooooklyn approved these changes Feb 22, 2024

View reviewed changes

CatsJuice approved these changes Feb 22, 2024

View reviewed changes

packages/frontend/component/src/ui/input/style.css.ts Outdated Show resolved Hide resolved

pengx17 force-pushed the xp/01-31-feat_core_tags_inline_editor branch from 4bf407f to b5195a0 Compare February 22, 2024 09:24

Brooooooklyn force-pushed the xp/01-29-feat_core_workspace_properties_setting branch from 98ef7e3 to 546d96c Compare February 22, 2024 09:38

Brooooooklyn force-pushed the xp/01-31-feat_core_tags_inline_editor branch from b5195a0 to bb8e601 Compare February 22, 2024 09:39

Brooooooklyn changed the base branch from xp/01-29-feat_core_workspace_properties_setting to canary February 22, 2024 09:48

graphite-app bot merged commit bb8e601 into canary Feb 22, 2024
34 checks passed

graphite-app bot deleted the xp/01-31-feat_core_tags_inline_editor branch February 22, 2024 09:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): tags inline editor #5748

feat(core): tags inline editor #5748

pengx17 commented Jan 30, 2024 •

edited

pengx17 commented Jan 30, 2024 •

edited

codecov bot commented Jan 30, 2024 •

edited

graphite-app bot commented Feb 22, 2024 •

edited

feat(core): tags inline editor #5748

feat(core): tags inline editor #5748

Conversation

pengx17 commented Jan 30, 2024 • edited

pengx17 commented Jan 30, 2024 • edited

codecov bot commented Jan 30, 2024 • edited

Codecov Report

graphite-app bot commented Feb 22, 2024 • edited

Merge activity

pengx17 commented Jan 30, 2024 •

edited

pengx17 commented Jan 30, 2024 •

edited

codecov bot commented Jan 30, 2024 •

edited

graphite-app bot commented Feb 22, 2024 •

edited