Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): flaky tests #5804

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix(core): flaky tests #5804

merged 1 commit into from
Feb 6, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 5, 2024

No description provided.

Copy link

graphite-app bot commented Feb 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@github-actions github-actions bot added test Related to test cases app:core labels Feb 5, 2024
Copy link

nx-cloud bot commented Feb 5, 2024

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (afccf3d) 65.18% compared to head (005c02f) 65.19%.

Files Patch % Lines
...d/core/src/modules/workspace/properties/adapter.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #5804   +/-   ##
=======================================
  Coverage   65.18%   65.19%           
=======================================
  Files         347      347           
  Lines       19626    19624    -2     
  Branches     1648     1649    +1     
=======================================
- Hits        12794    12793    -1     
+ Misses       6612     6611    -1     
  Partials      220      220           
Flag Coverage Δ
server-test 71.49% <ø> (ø)
unittest 46.41% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 02-05-feat_test_add_an_option_to_throttle_cpu_in_e2e branch from bd505a1 to 6d92652 Compare February 5, 2024 10:06
@pengx17 pengx17 force-pushed the 02-05-fix_core_flaky_tests branch 3 times, most recently from 2c6b65b to a158563 Compare February 6, 2024 03:08
Copy link

graphite-app bot commented Feb 6, 2024

Merge activity

@pengx17 pengx17 force-pushed the 02-05-feat_test_add_an_option_to_throttle_cpu_in_e2e branch from 6d92652 to afccf3d Compare February 6, 2024 03:21
@pengx17 pengx17 changed the base branch from 02-05-feat_test_add_an_option_to_throttle_cpu_in_e2e to canary February 6, 2024 03:29
@graphite-app graphite-app bot merged commit 005c02f into canary Feb 6, 2024
34 checks passed
@graphite-app graphite-app bot deleted the 02-05-fix_core_flaky_tests branch February 6, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants