Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): use fractional indexing for sorting #5809

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 6, 2024

use https://github.com/rocicorp/fractional-indexing to enable better sorting logic for crdt app

Copy link

graphite-app bot commented Feb 6, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link

nx-cloud bot commented Feb 6, 2024

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (372b4da) 64.34% compared to head (2df8f29) 64.44%.

Files Patch % Lines
...ages/frontend/core/src/hooks/use-affine-adapter.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5809      +/-   ##
==========================================
+ Coverage   64.34%   64.44%   +0.10%     
==========================================
  Files         360      360              
  Lines       19945    19946       +1     
  Branches     1701     1702       +1     
==========================================
+ Hits        12833    12854      +21     
+ Misses       6892     6872      -20     
  Partials      220      220              
Flag Coverage Δ
server-test 71.35% <ø> (+0.12%) ⬆️
unittest 45.15% <71.42%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 29632a7 to b7c13ac Compare February 7, 2024 10:00
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch 2 times, most recently from 3d45036 to 79ed4e3 Compare February 7, 2024 10:59
@github-actions github-actions bot added the test Related to test cases label Feb 7, 2024
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch 2 times, most recently from 554a1d0 to e8a8f5c Compare February 22, 2024 02:59
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from 79ed4e3 to 20a0804 Compare February 22, 2024 03:03
@pengx17 pengx17 changed the base branch from xp/02-01-test_core_add_tests_for_page_info_ui to canary February 22, 2024 03:03
@github-actions github-actions bot added mod:i18n Related to i18n mod:component labels Feb 22, 2024
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from 20a0804 to 2c2b7c0 Compare February 22, 2024 03:32
@pengx17 pengx17 changed the base branch from canary to xp/02-01-test_core_add_tests_for_page_info_ui February 22, 2024 03:32
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 94a606f to 26a77b4 Compare February 22, 2024 03:42
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from 2c2b7c0 to ce2bbc0 Compare February 22, 2024 03:42
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 26a77b4 to b4fcac3 Compare February 22, 2024 03:52
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from ce2bbc0 to 970ee58 Compare February 22, 2024 03:52
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from b4fcac3 to cd50a04 Compare February 22, 2024 04:04
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from 970ee58 to d6a09fd Compare February 22, 2024 04:04
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from cd50a04 to e85a727 Compare February 22, 2024 04:06
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from d6a09fd to 305f8f4 Compare February 22, 2024 04:07
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from e85a727 to 8c88f63 Compare February 22, 2024 04:42
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from 305f8f4 to dcfcd09 Compare February 22, 2024 04:42
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 8c88f63 to 8919212 Compare February 22, 2024 07:28
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from dcfcd09 to a716a8a Compare February 22, 2024 07:28
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 8919212 to 9d538bb Compare February 22, 2024 07:55
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from a716a8a to 819ef3e Compare February 22, 2024 07:55
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 9d538bb to b810be8 Compare February 22, 2024 07:57
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from 819ef3e to 3a0be85 Compare February 22, 2024 07:57
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from b810be8 to bc65a31 Compare February 22, 2024 08:05
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from 3a0be85 to c6b0580 Compare February 22, 2024 08:05
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from bc65a31 to 86b62e3 Compare February 22, 2024 08:13
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from c6b0580 to 41cc83b Compare February 22, 2024 08:13
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 86b62e3 to 0e2d426 Compare February 22, 2024 08:25
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch 2 times, most recently from 517238f to 0ea20b3 Compare February 22, 2024 08:54
@pengx17 pengx17 force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 0e2d426 to 4b608f8 Compare February 22, 2024 09:24
@pengx17 pengx17 force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from 0ea20b3 to dd0e302 Compare February 22, 2024 09:24
Copy link

graphite-app bot commented Feb 22, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the xp/02-01-test_core_add_tests_for_page_info_ui branch from 4b608f8 to 372b4da Compare February 22, 2024 09:39
@Brooooooklyn Brooooooklyn force-pushed the 02-06-refactor_core_use_fractional_indexing_for_sorting branch from dd0e302 to 2df8f29 Compare February 22, 2024 09:40
@Brooooooklyn Brooooooklyn changed the base branch from xp/02-01-test_core_add_tests_for_page_info_ui to canary February 22, 2024 09:50
@graphite-app graphite-app bot merged commit 2df8f29 into canary Feb 22, 2024
34 checks passed
@graphite-app graphite-app bot deleted the 02-06-refactor_core_use_fractional_indexing_for_sorting branch February 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:component mod:i18n Related to i18n test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants