Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow keyboard navigation in tags inline editor #7378

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jun 28, 2024

fix AF-966

  • Allow using arrowup/down to navigate the tag list candidates; press enter to add the currently focused tag option;
  • Allow using arrowleft/right to navigate the inline tag list (selected) and use backspace to delete focused tag.

Copy link
Collaborator Author

pengx17 commented Jun 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added test Related to test cases app:core labels Jun 28, 2024
Copy link

nx-cloud bot commented Jun 28, 2024

Copy link

graphite-app bot commented Jun 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 marked this pull request as ready for review June 28, 2024 15:27
@graphite-app graphite-app bot requested review from EYHN, CatsJuice, JimmFly and forehalo and removed request for EYHN June 28, 2024 15:27
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 2.04082% with 48 lines in your changes missing coverage. Please review.

Project coverage is 28.91%. Comparing base (c62d79a) to head (2a6ea3c).

Files Patch % Lines
...ents/affine/page-properties/tags-inline-editor.tsx 2.04% 48 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7378       +/-   ##
===========================================
- Coverage   57.23%   28.91%   -28.33%     
===========================================
  Files         902      702      -200     
  Lines       39401    16656    -22745     
  Branches     4417     2971     -1446     
===========================================
- Hits        22552     4816    -17736     
+ Misses      16497    11538     -4959     
+ Partials      352      302       -50     
Flag Coverage Δ
server-test ?
unittest 28.91% <2.04%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 06-28-feat_core_allow_keyboard_navigation_in_tags_inline_editor branch 2 times, most recently from 42fdb9b to 421f98d Compare July 1, 2024 04:09
@pengx17 pengx17 requested a review from EYHN July 1, 2024 04:23
Copy link

graphite-app bot commented Jul 2, 2024

Merge activity

fix AF-966

- Allow using arrowup/down to navigate the tag list candidates; press enter to add the currently focused tag option;
- Allow using arrowleft/right to navigate the inline tag list (selected) and use backspace to delete focused tag.
@pengx17 pengx17 force-pushed the 06-28-feat_core_allow_keyboard_navigation_in_tags_inline_editor branch from 421f98d to 2a6ea3c Compare July 2, 2024 14:25
@graphite-app graphite-app bot merged commit 2a6ea3c into canary Jul 2, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 06-28-feat_core_allow_keyboard_navigation_in_tags_inline_editor branch July 2, 2024 14:36
forehalo pushed a commit that referenced this pull request Jul 3, 2024
fix AF-966

- Allow using arrowup/down to navigate the tag list candidates; press enter to add the currently focused tag option;
- Allow using arrowleft/right to navigate the inline tag list (selected) and use backspace to delete focused tag.
@abhi9dev
Copy link

hey @pengx17 I noticed that for the first time when you add the tag using enter keyword it happens successfully, but for the second time when I try to add the tag using enter keyword it fails, I have to manually click on the create tag-name option from dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants