-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): allow keyboard navigation in tags inline editor #7378
feat(core): allow keyboard navigation in tags inline editor #7378
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2a6ea3c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #7378 +/- ##
===========================================
- Coverage 57.23% 28.91% -28.33%
===========================================
Files 902 702 -200
Lines 39401 16656 -22745
Branches 4417 2971 -1446
===========================================
- Hits 22552 4816 -17736
+ Misses 16497 11538 -4959
+ Partials 352 302 -50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
42fdb9b
to
421f98d
Compare
Merge activity
|
fix AF-966 - Allow using arrowup/down to navigate the tag list candidates; press enter to add the currently focused tag option; - Allow using arrowleft/right to navigate the inline tag list (selected) and use backspace to delete focused tag.
421f98d
to
2a6ea3c
Compare
fix AF-966 - Allow using arrowup/down to navigate the tag list candidates; press enter to add the currently focused tag option; - Allow using arrowleft/right to navigate the inline tag list (selected) and use backspace to delete focused tag.
hey @pengx17 I noticed that for the first time when you add the tag using enter keyword it happens successfully, but for the second time when I try to add the tag using enter keyword it fails, I have to manually click on the create tag-name option from dropdown. |
fix AF-966