Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated integrations #2102

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Remove deprecated integrations #2102

merged 1 commit into from
Aug 12, 2022

Conversation

nunofmn
Copy link
Contributor

@nunofmn nunofmn commented Jun 30, 2022

🌟 What does this PR do?

  • 5136956 - chore(integration): Remove deprecated integrations

🐛 Recommendations for testing

  • Check if Track extension still works properly. 👌
  • Check Settings page and try to enable a few integrations and test them out.

📝 Links to relevant issues or information

Closes #2101

@nunofmn nunofmn requested a review from Alissonsz June 30, 2022 14:35
@nunofmn nunofmn self-assigned this Jun 30, 2022
Copy link
Contributor

@Alissonsz Alissonsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a question and everything else LGTM, great cleanup!!

'agenocrm.com': {
url: '*://*.agenocrm.com/*',
name: 'AgenoCRM',
file: 'minicrm.js'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also delete this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because it's used here:

'minicrm.pl': {
url: '*://*.minicrm.pl/*',
name: 'Minicrm',
clone: 'true'
},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right!

@nunofmn nunofmn force-pushed the 2101/cleanup-integrations branch from 5136956 to a18b098 Compare July 1, 2022 09:50
@nunofmn nunofmn merged commit 89a0582 into master Aug 12, 2022
@nunofmn nunofmn deleted the 2101/cleanup-integrations branch August 12, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup integrations
2 participants