Use Result in API to more closely match Tsdl #9
Conversation
There was a problem hiding this comment.
Just a minor update -- I started the work to merge this and your other PR, which has forced me to fix the broken CI builds and a bunch of other little things. I can make the change I've suggested here when I do the merge (I'm also going to make some minor adjustments in the tsdl-ttf PR), but I wanted to let you know that despite the delay, this is slowly moving forward. (Wrangling with Travis CI is always a hassle.)
| @@ -1,6 +1,11 @@ | |||
| open Ctypes | |||
| open Foreign | |||
| open Tsdl | |||
| open Result | |||
|
|
|||
| type 'a result = 'a Sdl.result | |||
There was a problem hiding this comment.
I think this type and error should go inside module Image for consistency with tsdl.
There was a problem hiding this comment.
agreed -- happy to commit it in if it helps; but don't want to get in your way at this point
|
Merged as commit 9bf2918 rather than through this PR due to minor adjustments. Thanks for your contribution and your patience. 0.2.0 should be available once the OPAM PR clears. tsdl-ttf and tsdl-mixer should follow shortly. |
This should resolve #5