-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation error when compiling tracing-subscriber 0.3 with time but without local-time #1683
Comments
Ah, my bad --- we should have separate |
hawkw
added a commit
that referenced
this issue
Oct 25, 2021
Currently, the `pub use` re-export for the `LocalTime` struct is enabled whenever the "time" feature flag is enabled. However, this type only _exists_ when the "local-time" feature flag is enabled, so enabling only the `time` feature results in a compilation error. This commit adds a separate `pub use` for `LocalTime` that's only enabled when the "local-time" feature is enabled. Fixes #1683
hawkw
added a commit
that referenced
this issue
Oct 25, 2021
…1685) ## Motivation Currently, the `pub use` re-export for the `LocalTime` struct is enabled whenever the "time" feature flag is enabled. However, this type only _exists_ when the "local-time" feature flag is enabled, so enabling only the `time` feature results in a compilation error. ## Solution This commit adds a separate `pub use` for `LocalTime` that's only enabled when the "local-time" feature is enabled. Fixes #1683
hawkw
added a commit
that referenced
this issue
Oct 25, 2021
…1685) ## Motivation Currently, the `pub use` re-export for the `LocalTime` struct is enabled whenever the "time" feature flag is enabled. However, this type only _exists_ when the "local-time" feature flag is enabled, so enabling only the `time` feature results in a compilation error. ## Solution This commit adds a separate `pub use` for `LocalTime` that's only enabled when the "local-time" feature is enabled. Fixes #1683
Thanks for the quick fix! |
No trouble at all --- sorry for the inconvenience! I've published v0.3.1 with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Version
Platform
Darwin djc-2019 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X86_64 x86_64
Crates
tracing-subscriber
Description
Upgrading from tracing-subscriber 0.2 to 0.3, I found that just replacing the chrono feature with time did not work:
The text was updated successfully, but these errors were encountered: